Advanced image compression: remove posterization #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the posterization filter from the advanced image compression settings to substantially reduce the CPU load which could cause image resizing to fail (see #150). After digging into the research @nwtn did to come up with these settings, it turns out that posterization only improves file sizes for PNGs and can actually lead to slightly larger file sizes for JPG images.
|
Raw data for the original experiments can be found here: https://github.com/nwtn/image-resize-tests/tree/optimization |
|
👍 (no idea why that one test failed, but it passed in the second run so I assume it's not legit) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the posterization filter from the advanced image compression
settings to substantially reduce the CPU load which could cause image
resizing to fail (see #150).
After digging into the research @nwtn did to come up with these
settings, it turns out that posterization only improves file sizes
for PNGs and can actually lead to slightly larger file sizes for
JPG images.